[fix](cloud-mow) get delete bitmap update lock should create a new Transaction when encounter TXN_TOO_OLD#44691
Closed
hust-hhb wants to merge 2 commits intoapache:masterfrom
Closed
[fix](cloud-mow) get delete bitmap update lock should create a new Transaction when encounter TXN_TOO_OLD#44691hust-hhb wants to merge 2 commits intoapache:masterfrom
hust-hhb wants to merge 2 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
gavinchou
requested changes
Dec 3, 2024
|
|
||
| void internal_get_tablet_stats(MetaServiceCode& code, std::string& msg, Transaction* txn, | ||
| void internal_get_tablet_stats(MetaServiceCode& code, std::string& msg, | ||
| std::unique_ptr<Transaction>& txn, std::shared_ptr<TxnKv>& txn_kv, |
Contributor
There was a problem hiding this comment.
This is a behavior change, semantic changed, txn atomic is not garanteed if we create a new txn.
Fix where this internal_get_tablet_stats() is called if we met TXN_TOO_OLD
Contributor
Author
There was a problem hiding this comment.
@gavinchou already change the code, take a look please
github-actions
bot
removed
the
approved
…ansaction when encounter TXN_TOO_OLD
hust-hhb
force-pushed
the
fix-get-lock
branch
from
13b8035 to
5f80108
Compare
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
gavinchou
reviewed
Dec 9, 2024
| code = MetaServiceCode::OK; | ||
| txn = nullptr; | ||
| retry++; | ||
| err = txn_kv_->create_txn(&txn); |
Contributor
There was a problem hiding this comment.
overwrite the txn cannot modify the "delete_bitmap_upldate_lock"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #37670
Problem Summary:
When the number of tablet is big, get delete bitmap update lock may cost over 5 seconds, which will lead to transaction timeout, we should create a new transaction to get the remaining tablet stats.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)